linux-kernel - RE: [PATCH 0/7] Enable UFS provisioning via Linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR04MB11372C75BFC9416BAF5E81A19A630@MWHPR04MB1137.namprd04.prod.outlook.com>
Date:   Thu, 31 May 2018 10:04:18 +0000
From:   Stanislav Nijnikov <Stanislav.Nijnikov@....com>
To:     Evan Green <evgreen@...omium.org>,
        Vinayak Holikatti <vinholikatti@...il.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     Gwendal Grignou <gwendal@...omium.org>,
        Alex Lemberg <Alex.Lemberg@....com>,
        Avri Altman <Avri.Altman@....com>
Subject: RE: [PATCH 0/7] Enable UFS provisioning via Linux

Hi Evan,
I have some generic notes:
- Why to create new sysfs entries for the configuration descriptor fields if they are just duplication of fields in the device and unit descriptors? And the sysfs representation of the device and unit descriptors is existing already.
- It would be nice to have some "packet" mode allowing to gather configuration changes and apply them at once, not one by one.
- Why to put documentation update in the separate patches?

Regards
Stanislav

> -----Original Message-----
> From: Evan Green <evgreen@...omium.org>
> Sent: Tuesday, May 29, 2018 9:18 PM
> To: Vinayak Holikatti <vinholikatti@...il.com>; James E.J. Bottomley <jejb@...ux.vnet.ibm.com>; Martin K. Petersen
> <martin.petersen@...cle.com>; Stanislav Nijnikov <Stanislav.Nijnikov@....com>; linux-kernel@...r.kernel.org; linux-
> scsi@...r.kernel.org
> Cc: Gwendal Grignou <gwendal@...omium.org>; Evan Green <evgreen@...omium.org>
> Subject: [PATCH 0/7] Enable UFS provisioning via Linux
> 
> This series enables provisioning UFS devices using the existing sysfs
> interface. This functionality is primarily useful along the assembly
> line, but might also be useful for end users that receive devices that
> aren't locked down.
> 
> Evan Green (7):
>   scsi: ufs: Add Configuration Descriptor to sysfs
>   scsi: ufs: Add config descriptor documentation
>   scsi: ufs: Make sysfs attributes writable
>   scsi: ufs: sysfs: Document attribute writability
>   scsi: ufs: Refactor descriptor read for write
>   scsi: ufs: Enable writing config descriptor
>   scsi: ufs: Update config descriptor documentation
> 
>  Documentation/ABI/testing/sysfs-driver-ufs | 174 ++++++++++++++++++++---
>  drivers/scsi/ufs/ufs-sysfs.c               | 217 ++++++++++++++++++++++++++---
>  drivers/scsi/ufs/ufs.h                     |  29 ++++
>  drivers/scsi/ufs/ufshcd.c                  |  89 ++++++++----
>  drivers/scsi/ufs/ufshcd.h                  |  16 ++-
>  5 files changed, 458 insertions(+), 67 deletions(-)
> 
> --
> 2.13.5