lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHp75VcorKkNiK+0m6cVsT2zccUMqSOibcod0BdobwT76YS4nw@mail.gmail.com>
Date:   Thu, 31 May 2018 13:35:38 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     João Paulo Rechi Vita <jprvita@...il.com>
Cc:     Corentin Chary <corentin.chary@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Linux Upstreaming Team <linux@...lessm.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wireless: Fix format specifier

On Wed, May 23, 2018 at 12:29 AM, João Paulo Rechi Vita
<jprvita@...il.com> wrote:
> From: João Paulo Rechi Vita <jprvita@...il.com>
>
> u64 should be printed with %llx instead of %x and cast to uint.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: João Paulo Rechi Vita <jprvita@...il.com>
> ---
>  drivers/platform/x86/asus-wireless.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
> index f086469ea740..6afd011de9e5 100644
> --- a/drivers/platform/x86/asus-wireless.c
> +++ b/drivers/platform/x86/asus-wireless.c
> @@ -72,7 +72,7 @@ static u64 asus_wireless_method(acpi_handle handle, const char *method,
>                 acpi_handle_err(handle,
>                                 "Failed to eval method %s, param %#x (%d)\n",
>                                 method, param, s);
> -       acpi_handle_debug(handle, "%s returned %#x\n", method, (uint) ret);
> +       acpi_handle_debug(handle, "%s returned %#llx\n", method, ret);
>         return ret;
>  }
>
> --
> 2.17.0
>



-- 
With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ