[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1527765086-19873-2-git-send-email-xieyisheng1@huawei.com>
Date: Thu, 31 May 2018 19:11:06 +0800
From: Yisheng Xie <xieyisheng1@...wei.com>
To: <linux-kernel@...r.kernel.org>
CC: <andy.shevchenko@...il.com>, Yisheng Xie <xieyisheng1@...wei.com>,
<linux-usb@...r.kernel.org>, Felipe Balbi <balbi@...nel.org>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Subject: [PATCH v2 01/21] usb: phy: use match_string() helper
match_string() returns the index of an array for a matching string,
which can be used instead of open coded variant.
Cc: linux-usb@...r.kernel.org
Cc: Felipe Balbi <balbi@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
---
v2:
- donot rename err to ret - per Andy
drivers/usb/phy/of.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/phy/of.c b/drivers/usb/phy/of.c
index 1ab134f..9d74081 100644
--- a/drivers/usb/phy/of.c
+++ b/drivers/usb/phy/of.c
@@ -28,16 +28,16 @@
enum usb_phy_interface of_usb_get_phy_mode(struct device_node *np)
{
const char *phy_type;
- int err, i;
+ int err;
err = of_property_read_string(np, "phy_type", &phy_type);
if (err < 0)
return USBPHY_INTERFACE_MODE_UNKNOWN;
- for (i = 0; i < ARRAY_SIZE(usbphy_modes); i++)
- if (!strcmp(phy_type, usbphy_modes[i]))
- return i;
+ err = match_string(usbphy_modes, ARRAY_SIZE(usbphy_modes), phy_type);
+ if (err < 0)
+ return USBPHY_INTERFACE_MODE_UNKNOWN;
- return USBPHY_INTERFACE_MODE_UNKNOWN;
+ return err;
}
EXPORT_SYMBOL_GPL(of_usb_get_phy_mode);
--
1.7.12.4
Powered by blists - more mailing lists