linux-kernel - Re: [PATCH v2 1/2] drm/blend: Add per-plane pixel blend mode property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo52NznSOWNvB_uOT4iQ-8+3A=ohhBe2os+jbEc=8pswn3A@mail.gmail.com>
Date:   Thu, 31 May 2018 15:51:37 +0100
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Lowry Li <lowry.li@....com>
Cc:     Liviu Dudau <liviu.dudau@....com>, David Airlie <airlied@...ux.ie>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        Mali DP Maintainers <malidp@...s.arm.com>,
        "Vetter, Daniel" <daniel.vetter@...el.com>, nd@....com
Subject: Re: [PATCH v2 1/2] drm/blend: Add per-plane pixel blend mode property

Hi Lowry,

Small drive-by suggestion. Haven't checked if others have pointed it
out previously :-\

On 30 May 2018 at 12:23, Lowry Li <lowry.li@....com> wrote:

> +/**
> + * drm_plane_create_blend_mode_property - create a new blend mode property
> + * @plane: drm plane
> + * @supported_modes: bitmask of supported modes, must include
> + *                  BIT(DRM_MODE_BLEND_PREMULTI)
> + *
There are two possible blend modes (ignoring 'none'), yet premult must
be supported.
What if the hardware can do only "coverage"?

One-liner explaining why things are as-is would be a great move.

HTH
Emil