linux-kernel - Re: [PATCH] block: Add block level changes for inline encryption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fc7786c-af85-d047-047f-44d4eded6124@kernel.dk>
Date:   Thu, 31 May 2018 09:46:07 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Ladvine D Almeida <Ladvine.DAlmeida@...opsys.com>,
        "ming.lei@...hat.com" <ming.lei@...hat.com>
Cc:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Manjunath M Bettegowda <Manjunath.MB@...opsys.com>,
        Prabu Thangamuthu <Prabu.T@...opsys.com>,
        Tejas Joglekar <Tejas.Joglekar@...opsys.com>,
        Joao Pinto <Joao.Pinto@...opsys.com>
Subject: Re: [PATCH] block: Add block level changes for inline encryption

On 5/31/18 1:47 AM, Ladvine D Almeida wrote:
> On Monday 28 May 2018 04:54 PM, Jens Axboe wrote:
>> On 5/28/18 7:43 AM, Ladvine D Almeida wrote:
>>> This patch introduces new variable under bio structure to
>>> facilitate inline encryption. This variable is used to
>>> associate I/O requests to crypto information.
>> Hard no on this, for two reasons:
>>
>> 1) Any additions to struct bio are scrutinized heavily and
>>    need strong justification.
> 
> Thanks for sharing your feedback on the patch.
> I am providing reference to an earlier article related to inline encryption support below:
> https://lwn.net/Articles/717754/

Took a quick look, and this looks like a classic case of something
that should just be a cloned bio. If you clone, you own the bi_private
field, which is what you need.

-- 
Jens Axboe