linux-kernel - Re: [PATCH v2] libata: Drop SanDisk SD7UB3Q*G1001 NOLPM quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180531154748.GS1351649@devbig577.frc2.facebook.com>
Date:   Thu, 31 May 2018 08:47:48 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org,
        "Richard W . M . Jones" <rjones@...hat.com>,
        Lorenzo Dalrio <lorenzo.dalrio@...il.com>
Subject: Re: [PATCH v2] libata: Drop SanDisk SD7UB3Q*G1001 NOLPM quirk

On Thu, May 31, 2018 at 01:21:07PM +0200, Hans de Goede wrote:
> Commit 184add2ca23c ("libata: Apply NOLPM quirk for SanDisk
> SD7UB3Q*G1001 SSDs") disabled LPM for SanDisk SD7UB3Q*G1001 SSDs.
> 
> This has lead to several reports of users of that SSD where LPM
> was working fine and who know have a significantly increased idle
> power consumption on their laptops.
> 
> Likely there is another problem on the T450s from the original
> reporter which gets exposed by the uncore reaching deeper sleep
> states (higher PC-states) due to LPM being enabled. The problem as
> reported, a hardfreeze about once a day, already did not sound like
> it would be caused by LPM and the reports of the SSD working fine
> confirm this. The original reporter is ok with dropping the quirk.
> 
> A X250 user has reported the same hard freeze problem and for him
> the problem went away after unrelated updates, I suspect some GPU
> driver stack changes fixed things.
> 
> TL;DR: The original reporters problem were triggered by LPM but not
> an LPM issue, so drop the quirk for the SSD in question.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1583207
> Cc: stable@...r.kernel.org
> Cc: Richard W.M. Jones <rjones@...hat.com>
> Cc: Lorenzo Dalrio <lorenzo.dalrio@...il.com>
> Reported-by: Lorenzo Dalrio <lorenzo.dalrio@...il.com>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>

Applied to libata/for-4.17-fixes.

Thanks.

-- 
tejun