linux-kernel - Re: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41bbf801-f060-2056-4015-b4d05c6831bb@broadcom.com>
Date:   Thu, 31 May 2018 10:24:16 -0700
From:   Ray Jui <ray.jui@...adcom.com>
To:     Clément Péron <peron.clem@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        Russell King <linux@...linux.org.uk>,
        linux-kernel@...r.kernel.org, Tony Lindgren <tony@...mide.com>,
        Laura Abbott <labbott@...hat.com>,
        Scott Branden <sbranden@...adcom.com>,
        Jon Mason <jonmason@...adcom.com>, Ray Jui <rjui@...adcom.com>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
        Clément Peron <clement.peron@...ialet.com>
Subject: Re: [PATCH v2 1/2] ARM: debug: Add Iproc UART3 debug addresses



On 5/31/2018 1:22 AM, Clément Péron wrote:
> Hi Rai,
> 
> On Wed, 30 May 2018 at 19:25, Ray Jui <ray.jui@...adcom.com> wrote:
>>
>> Hi Clément,
>>
>> Correct me if I'm wrong, but I thought the trend is to move to use
>> earlycon that can be activated from kernel command line for early print
>> before the serial driver is loaded.
>>
>> Have you tried earlcon?
> No, only tested this method.
> 
> Thanks,
> Clement
> 

If I remember it correctly, I think the trend is to use earlycon. There 
are obvious shortcomings by making this configuration compile time based.

>>
>> Thanks,
>>
>> Ray
>>
>> On 5/30/2018 6:19 AM, Clément Péron wrote:
>>> From: Clément Peron <clement.peron@...ialet.com>
>>>
>>> Broadcom Iproc SoCs typically use the UART3 for
>>> debug/console, provide a known good location for that.
>>>
>>> Signed-off-by: Clément Peron <clement.peron@...ialet.com>
>>> ---
>>>
>>>    arch/arm/Kconfig.debug | 12 +++++++++++-
>>>    1 file changed, 11 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>>> index 199ebc1c4538..4ea9d5793b91 100644
>>> --- a/arch/arm/Kconfig.debug
>>> +++ b/arch/arm/Kconfig.debug
>>> @@ -207,6 +207,14 @@ choice
>>>                depends on ARCH_BCM_HR2
>>>                select DEBUG_UART_8250
>>>
>>> +     config DEBUG_BCM_IPROC_UART3
>>> +             bool "Kernel low-level debugging on BCM IPROC UART3"
>>> +             depends on ARCH_BCM_CYGNUS
>>> +             select DEBUG_UART_8250
>>> +             help
>>> +               Say Y here if you want the debug print routines to direct
>>> +               their output to the third serial port on these devices.
>>> +
>>>        config DEBUG_BCM_KONA_UART
>>>                bool "Kernel low-level debugging messages via BCM KONA UART"
>>>                depends on ARCH_BCM_MOBILE
>>> @@ -1557,6 +1565,7 @@ config DEBUG_UART_PHYS
>>>        default 0x18000400 if DEBUG_BCM_HR2
>>>        default 0x18010000 if DEBUG_SIRFATLAS7_UART0
>>>        default 0x18020000 if DEBUG_SIRFATLAS7_UART1
>>> +     default 0x18023000 if DEBUG_BCM_IPROC_UART3
>>>        default 0x1c090000 if DEBUG_VEXPRESS_UART0_RS1
>>>        default 0x20001000 if DEBUG_HIP01_UART
>>>        default 0x20060000 if DEBUG_RK29_UART0
>>> @@ -1676,6 +1685,7 @@ config DEBUG_UART_VIRT
>>>        default 0xf1002000 if DEBUG_MT8127_UART0
>>>        default 0xf1006000 if DEBUG_MT6589_UART0
>>>        default 0xf1009000 if DEBUG_MT8135_UART3
>>> +     default 0xf1023000 if DEBUG_BCM_IPROC_UART3
>>>        default 0xf11f1000 if DEBUG_VERSATILE
>>>        default 0xf1600000 if DEBUG_INTEGRATOR
>>>        default 0xf1c28000 if DEBUG_SUNXI_UART0
>>> @@ -1791,7 +1801,7 @@ config DEBUG_UART_8250_WORD
>>>                DEBUG_KEYSTONE_UART0 || DEBUG_KEYSTONE_UART1 || \
>>>                DEBUG_ALPINE_UART0 || \
>>>                DEBUG_DAVINCI_DMx_UART0 || DEBUG_DAVINCI_DA8XX_UART1 || \
>>> -             DEBUG_DAVINCI_DA8XX_UART2 || \
>>> +             DEBUG_DAVINCI_DA8XX_UART2 || DEBUG_BCM_IPROC_UART3 || \
>>>                DEBUG_BCM_KONA_UART || DEBUG_RK32_UART2
>>>
>>>    config DEBUG_UART_8250_PALMCHIP
>>>