linux-kernel - Re: [PATCH v6 0/4] enable early printing of hashed pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180531145253.02daa5d4@vmware.local.home>
Date:   Thu, 31 May 2018 14:52:53 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        "Theodore Ts'o" <tytso@....edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/4] enable early printing of hashed pointers

On Mon, 28 May 2018 11:46:38 +1000
"Tobin C. Harding" <me@...in.cc> wrote:

> Steve,

Hi Tobin,

Sorry for the late reply, I'm currently at a conference and have had
little time to read email.

> 
> Could you please take a quick squiz at the final 2 patches if you get a
> chance.  I assumed we are in preemptible context during early_init based
> on your code (and code comment) and called static_branch_disable()
> directly if hw RNG returned keying material.  It's a pretty simple
> change but I'd love to get someone else to check I've not noob'ed it.

I can take a look, and perhaps do some tests. But it was Anna-Maria
that originally triggered the issue. She's on Cc, perhaps she can try
this and see if it works.

I'll still pull the patches and add some injections to see how it works.

Thanks!

-- Steve