linux-kernel - Re: [PATCH] aic94xx: set error code on an error path in aic94xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VdAWzAB1K3bGEAgM28ZZFYa-92JqERy=jKd1Fc_738eBg@mail.gmail.com>
Date:   Thu, 31 May 2018 22:15:45 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Peter Melnichenko <melnichenko@...ras.ru>
Cc:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] aic94xx: set error code on an error path in aic94xx_init

On Thu, May 31, 2018 at 9:28 PM, Peter Melnichenko
<melnichenko@...ras.ru> wrote:
> When sas_domain_attach_transport returns NULL, aic94xx_init
> frees acquired resources but returns err equal to 0, as
> assigned by a previous statement.
>
> The patch sets err to -ENOMEM before jumping to the error label.

Wouldn't be better to fix a callee to return proper error code and...

>         aic94xx_transport_template =
>                 sas_domain_attach_transport(&aic94xx_transport_functions);
> -       if (!aic94xx_transport_template)
> +       if (!aic94xx_transport_template) {
> +               err = -ENOMEM;
>                 goto out_destroy_caches;
> +       }

this becomes

err = _attach_();
if (err < 0)
 goto ;
_template = err;

?

-- 
With Best Regards,
Andy Shevchenko