linux-kernel - Re: [PATCH] IB/mad: Use ID allocator routines to allocate agent number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BCE55284-7E90-4315-B5E3-588D5823D50A@oracle.com>
Date:   Thu, 31 May 2018 21:54:40 +0200
From:   Håkon Bugge <haakon.bugge@...cle.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Hans Westgaard Ry <hans.westgaard.ry@...cle.com>,
        jackm <jackm@....mellanox.co.il>,
        Doug Ledford <dledford@...hat.com>,
        Daniel Jurgens <danielj@...lanox.com>,
        Parav Pandit <parav@...lanox.com>,
        Pravin Shedge <pravin.shedge4linux@...il.com>,
        OFED mailing list <linux-rdma@...r.kernel.org>,
        linux-kernel@...r.kernel.org, Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH] IB/mad: Use ID allocator routines to allocate agent
 number



> On 31 May 2018, at 00:09, Jason Gunthorpe <jgg@...pe.ca> wrote:
> 
> On Wed, May 30, 2018 at 10:07:16PM +0200, Håkon Bugge wrote:
>> 
>> 
>>> On 30 May 2018, at 17:10, Jason Gunthorpe <jgg@...pe.ca> wrote:
>>> 
>>> On Wed, May 30, 2018 at 02:22:56PM +0200, Hans Westgaard Ry wrote:
>>> 
>>>> We came up with this code snippet which we think handles both preventing
>>>> immediate re-use and too big/wrapping...
>>> 
>>> Isn't this basically the same as idr_alloc_cyclic ?
>> 
>> I draw my statement back. The idr_alloc_cyclic() is the family of idr's that associates a pointer with the bit. Hence, each bit is a bit + 64b.
>> 
>> That's why we ended up with Hans' pseudo code.
> 
> Okay, fair enough.
> 
> Is it worth adding a ida_get_new_cyclic for this?

My initial reaction was "no", but then I found the same cyclic behaviour in drivers/net/ipvlan/ipvlan_main.c

Then in my opinion, it makes sense to create a ida_simple_get_cyclic()


Thxs, Håkon