linux-kernel - [PATCH v3 1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180531222144.26739-2-s-anna@ti.com>
Date:   Thu, 31 May 2018 17:21:43 -0500
From:   Suman Anna <s-anna@...com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
CC:     Viresh Kumar <viresh.kumar@...aro.org>,
        Dave Gerlach <d-gerlach@...com>, Tero Kristo <t-kristo@...com>,
        <linux-pm@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Suman Anna <s-anna@...com>,
        Zumeng Chen <zumeng.chen@...il.com>, <stable@...r.kernel.org>
Subject: [PATCH v3 1/2] cpufreq: ti-cpufreq: Fix an incorrect error return value

Commit 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when
failure") has fixed a memory leak in the failure path, however
the patch returned a positive value on get_cpu_device() failure
instead of the previous negative value. Fix this incorrect error
return value properly.

Fixes: 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure")
Cc: Zumeng Chen <zumeng.chen@...il.com>
Cc: <stable@...r.kernel.org> # v4.14+
Signed-off-by: Suman Anna <s-anna@...com>
Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
---
 drivers/cpufreq/ti-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
index 6ba709b6f095..896caba5dfe5 100644
--- a/drivers/cpufreq/ti-cpufreq.c
+++ b/drivers/cpufreq/ti-cpufreq.c
@@ -226,7 +226,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev)
 	opp_data->cpu_dev = get_cpu_device(0);
 	if (!opp_data->cpu_dev) {
 		pr_err("%s: Failed to get device for CPU0\n", __func__);
-		ret = ENODEV;
+		ret = -ENODEV;
 		goto free_opp_data;
 	}
 
-- 
2.17.0