linux-kernel - Re: [PATCH v1 2/3] USB: DT probing support to ehci-npcm7xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180531041430.GA2862@rob-hp-laptop>
Date:   Wed, 30 May 2018 23:14:30 -0500
From:   Rob Herring <robh@...nel.org>
To:     avifishman70@...il.com
Cc:     gregkh@...uxfoundation.org, stern@...land.harvard.edu,
        tmaimon77@...il.com, venture@...gle.com, yuenn@...gle.com,
        brendanhiggins@...gle.com, mathias.nyman@...ux.intel.com,
        bjorn.andersson@...aro.org, jhogan@...nel.org, albeu@...e.fr,
        chunfeng.yun@...iatek.com, tony@...mide.com,
        baolu.lu@...ux.intel.com, elder@...aro.org, digetx@...il.com,
        kstewart@...uxfoundation.org, hdegoede@...hat.com,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        openbmc@...ts.ozlabs.org, mark.rutland@....com,
        devicetree@...r.kernel.org, davem@...emloft.net,
        mchehab+samsung@...nel.org, akpm@...ux-foundation.org,
        rdunlap@...radead.org
Subject: Re: [PATCH v1 2/3] USB: DT probing support to ehci-npcm7xx

On Tue, May 29, 2018 at 11:35:34AM +0300, avifishman70@...il.com wrote:
> From: Avi Fishman <AviFishman70@...il.com>
> 
> Device Tree documentation for Nuvoton npcm7xx EHCI driver.

Bindings are for drivers, but for h/w.

> 
> Signed-off-by: Avi Fishman <AviFishman70@...il.com>
> ---
>  Documentation/devicetree/bindings/usb/npcm7xx-usb.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
> new file mode 100644
> index 000000000000..628692dff7e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/npcm7xx-usb.txt
> @@ -0,0 +1,18 @@
> +Nuvoton NPCM7XX SoC USB controllers:
> +-----------------------------
> +
> +EHCI:
> +-----
> +
> +Required properties:
> +- compatible: "nuvoton,npcm750-ehci"

And usb-ehci? Though I would just drop it. It is pretty useless.

> +  that services interrupts for this device

This line goes below.

> +- interrupts: Should contain the EHCI interrupt
> +
> +Example:
> +
> +	ehci@...00000 {
> +		compatible = "nuvoton,npcm750-ehci", "usb-ehci";
> +		reg = <0xf0806000 0x1000>;
> +		interrupts = <0 61 4>;
> +	};
> -- 
> 2.14.1
>