linux-kernel - Re: [PATCH v3 1/6] mtd: rawnand: add Reed-Solomon error correction algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180601154326.6c60c579@bbrezillon>
Date:   Fri, 1 Jun 2018 15:43:26 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Stefan Agner <stefan@...er.ch>
Cc:     mark.rutland@....com, devicetree@...r.kernel.org,
        pgaikwad@...dia.com, dev@...xeye.de, mirza.krak@...il.com,
        benjamin.lindqvist@...ian.se, pdeschrijver@...dia.com,
        miquel.raynal@...tlin.com, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, jonathanh@...dia.com, marek.vasut@...il.com,
        thierry.reding@...il.com, linux-mtd@...ts.infradead.org,
        krzk@...nel.org, richard@....at, linux-tegra@...r.kernel.org,
        digetx@...il.com, computersforpeace@...il.com, dwmw2@...radead.org,
        marcel@...wiler.com
Subject: Re: [PATCH v3 1/6] mtd: rawnand: add Reed-Solomon error correction
 algorithm

On Fri, 01 Jun 2018 15:34:33 +0200
Stefan Agner <stefan@...er.ch> wrote:

> On 01.06.2018 11:25, Boris Brezillon wrote:
> > On Fri, 1 Jun 2018 09:26:00 +0200
> > Boris Brezillon <boris.brezillon@...tlin.com> wrote:
> >   
> >> On Fri,  1 Jun 2018 00:16:32 +0200
> >> Stefan Agner <stefan@...er.ch> wrote:
> >>  
> >> > Add Reed-Solomon (RS) to the enumeration of ECC algorithms.
> >> >
> >> > Signed-off-by: Stefan Agner <stefan@...er.ch>  
> >>
> >> Reviewed-by: Boris Brezillon <boris.brezillon@...tlin.com>
> >>  
> >> > ---
> >> >  drivers/mtd/nand/raw/nand_base.c | 1 +
> >> >  include/linux/mtd/rawnand.h      | 1 +  
> > 
> > Hm, you forgot to update Documentation/devicetree/bindings/mtd/nand.txt.
> >   
> 
> Yeah I was not sure about that. Currently it says:
> 
> - nand-ecc-algo: string, algorithm of NAND ECC.                         
>                                                                    
>                  Supported values are: "hamming", "bch".
> 
> Is supported meant by software ECC here? I feel "supported" is a rather
> strong word since it is clearly controller dependent whether it is
> actually supported...

I guess "valid values" or "accepted values" would be more appropriate
here.