linux-kernel - Re: 4.13..4.14 scheduling overhead regression (bisected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Jun 2018 08:09:20 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Mike Galbraith <efault@....de>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Lutomirski <luto@...nel.org>
Subject: Re: 4.13..4.14 scheduling overhead regression (bisected - b956575bed91)

On Fri, Jun 1, 2018 at 6:21 AM Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Fri, Jun 01, 2018 at 02:57:53PM +0200, Mike Galbraith wrote:
> > b956575bed91ecfb136a8300742ecbbf451471ab is the first bad commit
> > commit b956575bed91ecfb136a8300742ecbbf451471ab
> > Author: Andy Lutomirski <luto@...nel.org>
> > Date:   Mon Oct 9 09:50:49 2017 -0700
> >
> >     x86/mm: Flush more aggressively in lazy TLB mode
>
> Oh boy... Maybe we should start looking at that optimization Andy
> mentioned.

Jolly.

>
> IIRC all page freeing does indeed go through tlb_remove_page(), it
> shouldn't be too hard to make that work.

Before we go too far down this rabbit hole, let's figure out what's
actually going on.  Mike, does your system have PCID?  If it does,
then my proposed optimization wouldn't do anything.

Can you try inverting the return value of
tlb_defer_switch_to_init_mm() and seeing if the result changes?