linux-kernel - Re: [PATCH] hwmon: (k10temp) Make function get_raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180601160903.GA4178@roeck-us.net>
Date:   Fri, 1 Jun 2018 09:09:03 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Colin King <colin.king@...onical.com>
Cc:     Clemens Ladisch <clemens@...isch.de>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (k10temp) Make function get_raw_temp static

On Fri, Jun 01, 2018 at 02:37:13PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The function get_raw_temp is local to the source and does not need to
> be in global scope, so make it static.
> 
> Cleans up sparse warning:
> drivers/hwmon/k10temp.c:149:14: warning: symbol 'get_raw_temp' was not
> declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/k10temp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index d3fae5a8e508..17c6460ae351 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -146,7 +146,7 @@ static void read_tempreg_nb_f17(struct pci_dev *pdev, u32 *regval)
>  		     F17H_M01H_REPORTED_TEMP_CTRL_OFFSET, regval);
>  }
>  
> -unsigned int get_raw_temp(struct k10temp_data *data)
> +static unsigned int get_raw_temp(struct k10temp_data *data)
>  {
>  	unsigned int temp;
>  	u32 regval;
> -- 
> 2.17.0
>