linux-kernel - Re: [PATCH] staging: pi433: add rw semaphore fixing concurrency issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180601160954.GA4895@kroah.com>
Date:   Fri, 1 Jun 2018 18:09:54 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Hugo Lefeuvre <hle@....eu.com>
Cc:     kernelnewbies@...nelnewbies.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: add rw semaphore fixing concurrency
 issues

On Fri, Jun 01, 2018 at 08:50:37AM -0400, Hugo Lefeuvre wrote:
> Add a rw semaphore fixing potential NULL pointer dereferences in the
> pi433 driver.

Unless you can measure the performance difference, do not use a rw
semaphore, just use a normal mutex please.  Odds are it will be faster
in the end and take up less space.

So please test, or if you can't test, just use a mutex.

thanks,

greg k-h