linux-kernel - Re: [PATCH] rtnetlink: Remove VLA usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180531.224926.26417889797461444.davem@davemloft.net>
Date:   Thu, 31 May 2018 22:49:26 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     fw@...len.de, dsahern@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtnetlink: Remove VLA usage

From: Kees Cook <keescook@...omium.org>
Date: Wed, 30 May 2018 15:20:52 -0700

> In the quest to remove all stack VLA usage from the kernel[1], this
> allocates the maximum size expected for all possible types and adds
> sanity-checks at both registration and usage to make sure nothing gets
> out of sync. This matches the proposed VLA solution for nfnetlink[2]. The
> values chosen here were based on finding assignments for .maxtype and
> .slave_maxtype and manually counting the enums:
> 
> slave_maxtype (max 33):
 ...
> maxtype (max 45):
 ...
> 
> This additionally changes maxtype and slave_maxtype fields to unsigned,
> since they're only ever using positive values.
> 
> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
> [2] https://patchwork.kernel.org/patch/10439647/
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>

Looks good, applied, thanks.