linux-kernel - Re: linux-next: build warnings after merge of the kbuild tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jK8F_R-CAt8h92ZG51s5eSnV+6FASLmYCWWgRX_2_m8zA@mail.gmail.com>
Date:   Thu, 31 May 2018 21:01:01 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the kbuild tree

On Thu, May 31, 2018 at 6:56 PM, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
> 2018-05-31 12:53 GMT+09:00 Kees Cook <keescook@...omium.org>:
>> On Wed, May 30, 2018 at 6:26 PM, Kees Cook <keescook@...omium.org> wrote:
>>> On Wed, May 30, 2018 at 6:12 PM, Masahiro Yamada
>>> <yamada.masahiro@...ionext.com> wrote:
>>>> Hi.
>>>> (+CC Kees)
>>>>
>>>> 2018-05-31 7:40 GMT+09:00 Stephen Rothwell <sfr@...b.auug.org.au>:
>>>>> Hi Masahiro,
>>>>>
>>>>> After merging the kbuild tree, today's linux-next build (x86_64
>>>>> allmodconfig) produced these warnings:
>>>>>
>>>>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy_rev7':
>>>>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:16563:1: warning: the frame size of 3136 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>>>>>  }
>>>>>  ^
>>>>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_workarounds_nphy_rev3':
>>>>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:16905:1: warning: the frame size of 2872 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>>>>>  }
>>>>>  ^
>>>>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c: In function 'wlc_phy_cal_txiqlo_nphy':
>>>>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26033:1: warning: the frame size of 2432 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>>>>>  }
>>>>>  ^
>>>>>
>>>>> I have no idea what caused these warnings to appear ... nothing in those
>>>>> functions looks too bad.
>>>>
>>>>
>>>> This has been triggered by the following commit:
>>>>
>>>>
>>>> commit 0e461945f3504e09b8ecf947b6398adce1287a28
>>>> Author: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>>> Date:   Mon May 28 18:22:07 2018 +0900
>>>>
>>>>     gcc-plugins: allow to enable GCC_PLUGINS for COMPILE_TEST
>>>>
>>>>
>>>>
>>>> CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL was previously disabled
>>>> for COMPILE_TEST, which is now enabled.

For the moment, can you add "depends on !COMPILE_TEST" to
CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL in your tree and I'll continue
to figure out what's happening?

Thanks!

-Kees

-- 
Kees Cook
Pixel Security