linux-kernel - Re: linux-next-20180601: build error in arch/arm64/kvm/hyp/hyp-entry.S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180601212619.6trmvqrgmbczekkt@armageddon.cambridge.arm.com>
Date:   Fri, 1 Jun 2018 22:26:19 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Stefan Wahren <stefan.wahren@...e.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Marc Zyngier <marc.zyngier@....com>,
        linux-arm-kernel@...ts.infradead.or,
        Will Deacon <will.deacon@....com>,
        linux-kernel@...r.kernel.org, kvmarm@...ts.cs.columbia.edu
Subject: Re: linux-next-20180601: build error in
 arch/arm64/kvm/hyp/hyp-entry.S

Hi Stefan,

On Fri, Jun 01, 2018 at 10:05:07PM +0200, Stefan Wahren wrote:
> i can't build todays linux-next-20180601 and get the following error message:
> 
> arch/arm64/kvm/hyp/hyp-entry.S: Assembler messages:
> arch/arm64/kvm/hyp/hyp-entry.S:128: Error: constant expression required at operand 3 -- `bfi x0,x1,#VCPU_WORKAROUND_2_FLAG_SHIFT,#1'
> 
> Related commit:
> arm64: KVM: Handle guest's ARCH_WORKAROUND_2 requests
> 
> Toolchain: gcc-linaro-7.2.1-2017.11-x86_64_aarch64-linux-gnu
> Kernel config: arm64/defconfig

Thanks for reporting this.

I can hit this as well. It looks like an #ifndef __ASSEMBLY__ in the
wrong place in arch/arm64/include/asm/kvm_asm.h. I can't tell whether it
was caused by a merge conflict resolution or just some unfortunate
interaction between the security fixes going via the arm64 tree and the
other arm64 KVM patches.

I'll have a proper look tomorrow.

-- 
Catalin