linux-kernel - Re: [PATCH v1 1/2] PCI: shpchp: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 3 Jun 2018 09:58:39 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Linux PCI <linux-pci@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Mario Limonciello <Mario.Limonciello@...l.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH v1 1/2] PCI: shpchp: Use dev_printk() for OSHP-related messages

On Sat, Jun 2, 2018 at 7:42 AM, Bjorn Helgaas <helgaas@...nel.org> wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
>
> Use dev_printk() for messages related to requesting control of SHPC hotplug
> via the OSHP method.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>  drivers/pci/hotplug/acpi_pcihp.c |   13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c
> index 7cc50cfef9c6..597d22aeefc1 100644
> --- a/drivers/pci/hotplug/acpi_pcihp.c
> +++ b/drivers/pci/hotplug/acpi_pcihp.c
> @@ -96,7 +96,7 @@ int acpi_get_hp_hw_control_from_firmware(struct pci_dev *pdev)
>         if (!handle) {
>                 /*
>                  * This hotplug controller was not listed in the ACPI name
> -                * space at all. Try to get acpi handle of parent pci bus.
> +                * space at all. Try to get ACPI handle of parent PCI bus.
>                  */
>                 struct pci_bus *pbus;
>                 for (pbus = pdev->bus; pbus; pbus = pbus->parent) {
> @@ -108,8 +108,8 @@ int acpi_get_hp_hw_control_from_firmware(struct pci_dev *pdev)
>
>         while (handle) {
>                 acpi_get_name(handle, ACPI_FULL_PATHNAME, &string);
> -               dbg("Trying to get hotplug control for %s\n",
> -                   (char *)string.pointer);
> +               pci_info(pdev, "Requesting control of SHPC hotplug via OSHP (%s)\n",
> +                        (char *)string.pointer);
>                 status = acpi_run_oshp(handle);
>                 if (ACPI_SUCCESS(status))
>                         goto got_one;
> @@ -121,13 +121,12 @@ int acpi_get_hp_hw_control_from_firmware(struct pci_dev *pdev)
>                         break;
>         }
>  no_control:
> -       dbg("Cannot get control of hotplug hardware for pci %s\n",
> -           pci_name(pdev));
> +       pci_info(pdev, "Cannot get control of SHPC hotplug\n");
>         kfree(string.pointer);
>         return -ENODEV;
>  got_one:
> -       dbg("Gained control for hotplug HW for pci %s (%s)\n",
> -           pci_name(pdev), (char *)string.pointer);
> +       pci_info(pdev, "Gained control of SHPC hotplug (%s)\n",
> +                (char *)string.pointer);
>         kfree(string.pointer);
>         return 0;
>  }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html