lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Jun 2018 01:36:13 +0000 From: Anson Huang <anson.huang@....com> To: Stephen Boyd <sboyd@...nel.org>, Stefan Wahren <stefan.wahren@...e.com>, Fabio Estevam <fabio.estevam@....com>, "kernel@...gutronix.de" <kernel@...gutronix.de>, "mark.rutland@....com" <mark.rutland@....com>, "matteo.lisi@...icam.com" <matteo.lisi@...icam.com>, "michael@...rulasolutions.com" <michael@...rulasolutions.com>, "mturquette@...libre.com" <mturquette@...libre.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org> CC: "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>, dl-linux-imx <linux-imx@....com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: RE: [PATCH 1/2] clk: imx6ul: add GPIO clock gates Hi, Stephen Anson Huang Best Regards! > -----Original Message----- > From: Stephen Boyd [mailto:sboyd@...nel.org] > Sent: Saturday, June 2, 2018 2:19 PM > To: Anson Huang <anson.huang@....com>; Stefan Wahren > <stefan.wahren@...e.com>; Fabio Estevam <fabio.estevam@....com>; > kernel@...gutronix.de; mark.rutland@....com; matteo.lisi@...icam.com; > michael@...rulasolutions.com; mturquette@...libre.com; > robh+dt@...nel.org; shawnguo@...nel.org > Cc: linux-clk@...r.kernel.org; dl-linux-imx <linux-imx@....com>; > devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; > linux-arm-kernel@...ts.infradead.org > Subject: Re: [PATCH 1/2] clk: imx6ul: add GPIO clock gates > > Quoting Stefan Wahren (2018-05-22 05:25:35) > > > +++ b/include/dt-bindings/clock/imx6ul-clock.h > > > @@ -242,20 +242,25 @@ > > > #define IMX6UL_CLK_CKO2_PODF 229 > > > #define IMX6UL_CLK_CKO2 230 > > > #define IMX6UL_CLK_CKO 231 > > > +#define IMX6UL_CLK_GPIO1 232 > > > +#define IMX6UL_CLK_GPIO2 233 > > > +#define IMX6UL_CLK_GPIO3 234 > > > +#define IMX6UL_CLK_GPIO4 235 > > > +#define IMX6UL_CLK_GPIO5 236 > > > > this change looks like a breakage of devicetree ABI. You are changing the > mean of the existing clock IDs on i.MX6ULL, which probably regress the > combination of older DTBs with newer kernel. > > > > Agreed. Why can't we just tack on more numbers at the end? Ah, yes, I saw 6ULL are at the end of 6UL, so added them in 6UL, but did NOT consider the old dtb support. Will send out a V2 patch to fix it, and I saw Fabio also sent a patch to fix the clko1/2 definition, I will do the V2 patch based on his patch. Anson. > > > > > > > /* For i.MX6ULL */ > > > -#define IMX6ULL_CLK_ESAI_PRED 232
Powered by blists - more mailing lists