linux-kernel - [PATCH v3 1/4] ima: Call audit_log_string() rather than logging it untrusted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  4 Jun 2018 16:54:52 -0400
From:   Stefan Berger <stefanb@...ux.vnet.ibm.com>
To:     zohar@...ux.vnet.ibm.com, paul@...l-moore.com,
        linux-integrity@...r.kernel.org, linux-audit@...hat.com
Cc:     sgrubb@...hat.com, linux-kernel@...r.kernel.org,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>
Subject: [PATCH v3 1/4] ima: Call audit_log_string() rather than logging it untrusted

The parameters passed to this logging function are all provided by
a privileged user and therefore we can call audit_log_string()
rather than audit_log_untrustedstring().

Signed-off-by: Stefan Berger <stefanb@...ux.vnet.ibm.com>
Suggested-by: Steve Grubb <sgrubb@...hat.com>
Acked-by: Paul Moore <paul@...l-moore.com>
---
 security/integrity/ima/ima_policy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c
index 8bbc18eb07eb..1d00db19d167 100644
--- a/security/integrity/ima/ima_policy.c
+++ b/security/integrity/ima/ima_policy.c
@@ -634,7 +634,7 @@ static void ima_log_string_op(struct audit_buffer *ab, char *key, char *value,
 		audit_log_format(ab, "%s<", key);
 	else
 		audit_log_format(ab, "%s=", key);
-	audit_log_untrustedstring(ab, value);
+	audit_log_string(ab, value);
 	audit_log_format(ab, " ");
 }
 static void ima_log_string(struct audit_buffer *ab, char *key, char *value)
-- 
2.13.6