lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 04 Jun 2018 19:04:14 +1000 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: Abhishek Goel <huntbag@...ux.vnet.ibm.com>, rjw@...ysocki.net, daniel.lezcano@...aro.org, paulus@...ba.org, mpe@...erman.id.au, linux-pm@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Cc: stewart@...ux.vnet.ibm.com Subject: Re: [PATCH v2] cpuidle/powernv : Add Description for cpuidle state On Mon, 2018-06-04 at 13:47 +0530, Abhishek Goel wrote: > + if (of_property_read_string_array(power_mgt, > + "ibm,cpu-idle-state-descs", descs, dt_idle_states) < 0) { > + of_property_read_string_array(power_mgt, > + "ibm,cpu-idle-state-names", descs, dt_idle_states); > + pr_warn("cpuidle-powernv: missing ibm,cpu-idle-state-descs in DT\n" > + "Name will be used for description\n"); > + } > > /* Is this a new property ? I'm not fan of adding yet another of those silly arrays. I would say this is the right time now to switch over to a node per state instead, as we discussed with Vaidy. Additionally, while doing that, we can provide the versioning mechanism I proposed so we can deal with state specific issues and erratas. Cheers, Ben.
Powered by blists - more mailing lists