linux-kernel - Re: dm-crypt: fix warning in shutdown path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPc1BN9KeTfv2t4bzv2iTCne+d19YimQ4UJO-g-qC30Lfg@mail.gmail.com>
Date:   Mon, 4 Jun 2018 11:31:40 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Mike Snitzer <snitzer@...hat.com>,
        Kent Overstreet <kent.overstreet@...il.com>,
        dm-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: dm-crypt: fix warning in shutdown path

On Sat, Jun 2, 2018 at 10:10 PM, Jens Axboe <axboe@...nel.dk> wrote:
> On 6/2/18 2:07 PM, Mike Snitzer wrote:
>> On Sat, Jun 02 2018 at  4:03pm -0400,
>> Jens Axboe <axboe@...nel.dk> wrote:
>>
>>> On 6/2/18 11:45 AM, Kent Overstreet wrote:
>>>> The counter for the number of allocated pages includes pages in the
>>>> mempool's reserve, so checking that the number of allocated pages is 0
>>>> needs to happen after we exit the mempool.
>>>
>>> Looks good, but needs a fixes line. I'll add one.
>>
>> Also needs the subject and header updated to reflect that it fixes the
>> crash (Krzysztof please verify):
>>
>> Reported-by: Krzysztof Kozlowski <krzk@...nel.org>
>> Acked-by: Mike Snitzer <snitzer@...hat.com>
>
> Indeed, I have added that. Thanks Mike.

Thanks for adding tags!

This fixes reported issue:
Tested-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof