linux-kernel - Re: [PATCH] blk-mq: return when BLK_MQ_S_STOPPED in blk_mq_run_work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180604104327.GA23074@ming.t460p>
Date:   Mon, 4 Jun 2018 18:43:28 +0800
From:   Ming Lei <ming.lei@...hat.com>
To:     Jianchao Wang <jianchao.w.wang@...cle.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-mq: return when BLK_MQ_S_STOPPED in
 blk_mq_run_work_fn

On Mon, Jun 04, 2018 at 05:03:55PM +0800, Jianchao Wang wrote:
> if hctx is stopped, don't run the queue in blk_mq_run_work_fn.
> 
> Fixes: 15fe8a9 (blk-mq: remove blk_mq_delay_queue())
> Cc: Ming Lei <ming.lei@...hat.com>
> Signed-off-by: Jianchao Wang <jianchao.w.wang@...cle.com>
> ---
>  block/blk-mq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 9ce9cac..d0ee928 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1578,7 +1578,7 @@ static void blk_mq_run_work_fn(struct work_struct *work)
>  	 * If we are stopped, don't run the queue.
>  	 */
>  	if (test_bit(BLK_MQ_S_STOPPED, &hctx->state))
> -		clear_bit(BLK_MQ_S_STOPPED, &hctx->state);
> +		return;
>  
>  	__blk_mq_run_hw_queue(hctx);
>  }
> -- 
> 2.7.4
> 

Reviewed-by: Ming Lei <ming.lei@...hat.com>

Thanks,
Ming