linux-kernel - RE: [PATCH] mm: Add conditions to avoid out-of-bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E490CD805F7529488761C40FD9D26EF12A6834EF@dggemm507-mbx.china.huawei.com>
Date:   Mon, 4 Jun 2018 11:27:26 +0000
From:   Nixiaoming <nixiaoming@...wei.com>
To:     Michal Hocko <mhocko@...nel.org>
CC:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "vdavydov.dev@...il.com" <vdavydov.dev@...il.com>,
        "hannes@...xchg.org" <hannes@...xchg.org>,
        "garsilva@...eddedor.com" <garsilva@...eddedor.com>,
        "ktkhai@...tuozzo.com" <ktkhai@...tuozzo.com>,
        "stummala@...eaurora.org" <stummala@...eaurora.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: RE: [PATCH] mm: Add conditions to avoid out-of-bounds

I'm very sorry. It was my mistake. 
it won't cross the border here.

Thanks 


-----Original Message-----
From: Michal Hocko [mailto:mhocko@...nel.org] 
Sent: Monday, June 04, 2018 7:20 PM
To: Nixiaoming <nixiaoming@...wei.com>
Cc: akpm@...ux-foundation.org; vdavydov.dev@...il.com; hannes@...xchg.org; garsilva@...eddedor.com; ktkhai@...tuozzo.com; stummala@...eaurora.org; linux-kernel@...r.kernel.org; linux-mm@...ck.org
Subject: Re: [PATCH] mm: Add conditions to avoid out-of-bounds

On Mon 04-06-18 18:37:35, nixiaoming wrote:
> In the function memcg_init_list_lru
> if call goto fail when i == 0, will cause out-of-bounds at lru->node[i]

How? All I can see is that the fail path does
	for (i = i - 1; i >= 0; i--)

so it will not do anything for i=0.
-- 
Michal Hocko
SUSE Labs