linux-kernel - Re: [alsa-devel] [PATCH] ALSA: usb-audio: remove redundant check on err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hin6ylqdt.wl-tiwai@suse.de>
Date:   Mon, 04 Jun 2018 13:53:18 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA: usb-audio: remove redundant check on err

On Mon, 04 Jun 2018 13:49:19 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> The check on err is redundant as both the true and false paths
> end up on a break statement. Remove the redundant check.
> 
> Detected by CoverityScan, CID#1268773 ("Identical code for different
> branches")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.


Takashi