linux-kernel - Re: WARNING and PANIC in irq_matrix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58b776f7-58ae-131b-47af-d85452794a0f@cn.fujitsu.com>
Date:   Mon, 4 Jun 2018 19:59:38 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     Song Liu <songliubraving@...com>,
        Song Liu <liu.song.a23@...il.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        open list <linux-kernel@...r.kernel.org>,
        Maor Gottlieb <maorg@...lanox.com>,
        Kernel Team <Kernel-team@...com>
Subject: Re: WARNING and PANIC in irq_matrix_free

Hi Thomas,

At 06/04/2018 07:17 PM, Thomas Gleixner wrote:
> On Mon, 4 Jun 2018, Dou Liyang wrote:
>> Here, why didn't we avoid this cleanup by
>>
>> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
>> index a75de0792942..0cc59646755f 100644
>> --- a/arch/x86/kernel/apic/vector.c
>> +++ b/arch/x86/kernel/apic/vector.c
>> @@ -821,6 +821,9 @@ static void free_moved_vector(struct apic_chip_data
>> *apicd)
>>           */
>>          WARN_ON_ONCE(managed);
>>
>> +       if (!vector)
>> +               return;
>> +
>>          trace_vector_free_moved(apicd->irq, cpu, vector, managed);
>>          irq_matrix_free(vector_matrix, cpu, vector, managed);
>>          per_cpu(vector_irq, cpu)[vector] = VECTOR_UNUSED;
>>
>> Is there something I didn't consider with? ;-)
> 
> Well, that just prevents the warning, but the hlist is already
> corrupted. So you'd just cure the symptom ...
> 

I see.

> I'm about to send a patch series which addresses that. Just need to finish
> writing changelogs.
> 

Thank you for telling me that.

Thanks,
	dou