linux-kernel - Re: [PATCH v2] mm: Change return type int to vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFqt6zaf1k1SvYXLrCXAvsAPC+jGQoKxR_LtUwNybdJosptQTQ@mail.gmail.com>
Date:   Mon, 4 Jun 2018 10:07:16 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Al Viro <viro@...iv.linux.org.uk>, Hugh Dickins <hughd@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        zi.yan@...rutgers.edu,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>, riel@...hat.com,
        pasha.tatashin@...cle.com, jschoenh@...zon.de,
        Kate Stewart <kstewart@...uxfoundation.org>,
        David Rientjes <rientjes@...gle.com>, tglx@...utronix.de,
        Peter Zijlstra <peterz@...radead.org>,
        Mel Gorman <mgorman@...e.de>, yang.s@...baba-inc.com,
        Minchan Kim <minchan@...nel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-kernel@...r.kernel.org, Linux-MM <linux-mm@...ck.org>
Subject: Re: [PATCH v2] mm: Change return type int to vm_fault_t for fault handlers

On Sun, Jun 3, 2018 at 3:31 AM, Matthew Wilcox <willy@...radead.org> wrote:
> On Sun, Jun 03, 2018 at 01:34:07AM +0530, Souptick Joarder wrote:
>> @@ -3570,9 +3571,8 @@ static int hugetlb_cow(struct mm_struct *mm, struct vm_area_struct *vma,
>>                       return 0;
>>               }
>>
>> -             ret = (PTR_ERR(new_page) == -ENOMEM) ?
>> -                     VM_FAULT_OOM : VM_FAULT_SIGBUS;
>> -             goto out_release_old;
>> +             ret = vmf_error(PTR_ERR(new_page));
>> +                     goto out_release_old;
>>       }
>>
>>       /*
>
> Something weird happened to the goto here

Didn't get it ? Do you refer to wrong indent in goto ?