linux-kernel - Re: [PATCH v2] kernel: event: core: Change return type to vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Jun 2018 10:50:35 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Peter Zijlstra <peterz@...radead.org>, mingo@...hat.com,
        acme@...nel.org,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        jolsa@...hat.com, namhyung@...nel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kernel: event: core: Change return type to vm_fault_t

On Mon, May 21, 2018 at 11:55 PM, Souptick Joarder <jrdr.linux@...il.com> wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Reviewed-by: Matthew Wilcox <mawilcox@...rosoft.com>
> ---
> v2: Updated the change log.
>     Acked by Peter Zijlstra.
>
>  kernel/events/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 96db9ae..d09f1c4 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -4918,11 +4918,11 @@ void perf_event_update_userpage(struct perf_event *event)
>  }
>  EXPORT_SYMBOL_GPL(perf_event_update_userpage);
>
> -static int perf_mmap_fault(struct vm_fault *vmf)
> +static vm_fault_t perf_mmap_fault(struct vm_fault *vmf)
>  {
>         struct perf_event *event = vmf->vma->vm_file->private_data;
>         struct ring_buffer *rb;
> -       int ret = VM_FAULT_SIGBUS;
> +       vm_fault_t ret = VM_FAULT_SIGBUS;
>
>         if (vmf->flags & FAULT_FLAG_MKWRITE) {
>                 if (vmf->pgoff == 0)
> --
> 1.9.1
>

Any further comment on this patch ?