linux-kernel - Re: [PATCH] PCI: access.c: Piggyback user config access on pci_read/write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02be2689d0b44afdb449b4dc17415b8f@ausx13mps321.AMER.DELL.COM>
Date:   Mon, 4 Jun 2018 16:14:36 +0000
From:   <Alex_Gagniuc@...lteam.com>
To:     <keith.busch@...el.com>, <mr.nuke.me@...il.com>
Cc:     <bhelgaas@...gle.com>, <Austin.Bolen@...l.com>,
        <Shyam.Iyer@...l.com>, <linux-pci@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: access.c: Piggyback user config access on
 pci_read/write_*()

On 6/4/2018 11:09 AM, Keith Busch wrote:
> On Mon, Jun 04, 2018 at 10:48:02AM -0500, Alexandru Gagniuc wrote:
>> +++ b/drivers/pci/access.c
>> @@ -223,16 +223,9 @@ int pci_user_read_config_##size						\
>>   	(struct pci_dev *dev, int pos, type *val)			\
>>   {									\
>>   	int ret = PCIBIOS_SUCCESSFUL;					\
>> -	u32 data = -1;							\
>>   	if (PCI_##size##_BAD)						\
>>   		return -EINVAL;						\
>> -	raw_spin_lock_irq(&pci_lock);				\
>> -	if (unlikely(dev->block_cfg_access))				\
>> -		pci_wait_cfg(dev);					\
>> -	ret = dev->bus->ops->read(dev->bus, dev->devfn,			\
>> -					pos, sizeof(type), &data);	\
>> -	raw_spin_unlock_irq(&pci_lock);				\
>> -	*val = (type)data;						\
>> +	ret = pci_read_config_##size(dev, pos, val);			\
>>   	return pcibios_err_to_errno(ret);				\
>>   }									\
> 
> If it wasn't for the block_cfg_access check for user access, this would
> have been a nice code reuse cleanup.

Great fresh catch! I'll get that fixed in v2.

Alex