linux-kernel - Re: [PATCH 15/19] sched/numa: Use group_weights to identify if migration degrades locality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1528138607.7898.119.camel@surriel.com>
Date:   Mon, 04 Jun 2018 14:56:47 -0400
From:   Rik van Riel <riel@...riel.com>
To:     Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 15/19] sched/numa: Use group_weights to identify if
 migration degrades locality

On Mon, 2018-06-04 at 15:30 +0530, Srikar Dronamraju wrote:
> 
> +	dist = node_distance(src_nid, dst_nid);
>  	if (numa_group) {
> -		src_faults = group_faults(p, src_nid);
> -		dst_faults = group_faults(p, dst_nid);
> +		src_weight = group_weight(p, src_nid, dist);
> +		dst_weight = group_weight(p, dst_nid, dist);
>  	} else {
> -		src_faults = task_faults(p, src_nid);
> -		dst_faults = task_faults(p, dst_nid);
> +		src_weight = task_weight(p, src_nid, dist);
> +		dst_weight = task_weight(p, dst_nid, dist);
>  	}
>  
> -	return dst_faults < src_faults;
> +	return dst_weight < src_weight;
>  }

While this is better in principle, in practice
task/group_weight is a LOT more expensive to
calculate than just comparing the faults.

This may be too expensive to do in the load
balancing code.

This patch regressed performance in your synthetic
test. How does it do for "real workload" style
benchmarks?

-- 
All Rights Reversed.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)