linux-kernel - Re: [PATCH] ACPI LID: increment wakeup count only when notified.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180604191956.GA223551@decatoncale.mtv.corp.google.com>
Date:   Mon, 4 Jun 2018 12:19:56 -0700
From:   Benson Leung <bleung@...gle.com>
To:     Ravi Chandra Sadineni <ravisadineni@...omium.org>
Cc:     rjw@...ysocki.net, lenb@...nel.org, ravisadineni@...gle.com,
        dmitry.torokhov@...il.com, tbroch@...gle.com,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        rajatja@...gle.com, furquan@...omium.org, bleung@...omium.org
Subject: Re: [PATCH] ACPI LID: increment wakeup count only when notified.

On Mon, Jun 04, 2018 at 11:26:12AM -0700, Ravi Chandra Sadineni wrote:
> Currently ACPI LID increments wakeup count irrespective of the wake source.
> This is because we call acpi_lid_initialize_state on every resume.
> Userland deamons using wakeup_count to identify the potential wake
> source for the last wake will be thrown off by this. Instead increment
> the wakeup count only when there is a FIXED_HARDWARE/NOTFIY_STATUS event.
> 
> Signed-off-by: Ravi Chandra Sadineni <ravisadineni@...omium.org>

Reviewed-by: Benson Leung <bleung@...omium.org>

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@...gle.com
Chromium OS Project
bleung@...omium.org

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)