[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK8P3a0v6sr_oZmYTZV7E-uJ8JdG6D8JqUesHDPkPY2UrWKdvw@mail.gmail.com>
Date: Tue, 5 Jun 2018 23:28:54 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Nick Desaulniers <ndesaulniers@...gle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
Andrey Ryabinin <aryabinin@...tuozzo.com>, akataria@...are.com,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Brijesh Singh <brijesh.singh@....com>,
Cao jin <caoj.fnst@...fujitsu.com>,
gregkh <gregkh@...uxfoundation.org>,
"H. Peter Anvin" <hpa@...or.com>,
Jan Kiszka <jan.kiszka@...mens.com>,
Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
Juergen Gross <jgross@...e.com>,
Josh Poimboeuf <jpoimboe@...hat.com>,
"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
Ingo Molnar <mingo@...hat.com>, mjg59@...gle.com,
Matthias Kaehlcke <mka@...omium.org>,
Philippe Ombredanne <pombredanne@...b.com>,
Steven Rostedt <rostedt@...dmis.org>,
Thomas Gleixner <tglx@...utronix.de>,
"Lendacky, Thomas" <thomas.lendacky@....com>, tweek@...gle.com,
linux-efi@...r.kernel.org,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"the arch/x86 maintainers" <x86@...nel.org>,
virtualization@...ts.linux-foundation.org, astrachan@...gle.com,
manojgupta@...gle.com, Greg Hackmann <ghackmann@...gle.com>,
sedat.dilek@...il.com, tstellar@...hat.com,
Kees Cook <keescook@...gle.com>,
Masahiro Yamada <yamada.masahiro@...ionext.com>,
Michal Marek <michal.lkml@...kovi.net>,
Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
Will Deacon <will.deacon@....com>, mawilcox@...rosoft.com,
David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline
On Tue, Jun 5, 2018 at 7:05 PM, Nick Desaulniers
<ndesaulniers@...gle.com> wrote:
>
> The semantics of extern inline has changed since gnu89. This means that
> folks using GCC versions >= 5.1 may see symbol redefinition errors at
> link time for subdirs that override KBUILD_CFLAGS (making the C standard
> used implicit) regardless of this patch. This has been cleaned up
> earlier in the patch set, but is left as a note in the commit message
> for future travelers.
I think the keyword you are missing is
__attribute__((gnu_inline))
which forces the gnu89 behavior on all compiler versions. It's been supported
since gcc-4.2, so it should not cause problems on any compiler that is able
to build an x86 kernel.
Arnd
Powered by blists - more mailing lists