linux-kernel - Re: [PATCH] riscv: add riscv-specific predefines to CHECKFLAGS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-82ddb68f-98e3-422d-9828-8bff3ee48512@palmer-si-x1c4>
Date:   Mon, 04 Jun 2018 18:18:51 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...ive.com>
To:     luc.vanoostenryck@...il.com
CC:     albert@...ive.com, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, luc.vanoostenryck@...il.com
Subject:     Re: [PATCH] riscv: add riscv-specific predefines to CHECKFLAGS

On Thu, 31 May 2018 08:42:01 PDT (-0700), luc.vanoostenryck@...il.com wrote:
> RISC-V uses the macro __riscv_xlen, predefined by GCC, to
> make the distinction between 32 or 64 bit code.
>
> However, sparse doesn't know anything about this macro
> which lead to wrong warnings and failures.
>
> Fix this by adding a define of __riscv_xlen to CHECKFLAGS
> and add one for __riscv too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
> ---
>  arch/riscv/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 76e958a54..6d4a5f6c3 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -71,6 +71,9 @@ KBUILD_CFLAGS_MODULE += $(call cc-option,-mno-relax)
>  # architectures.  It's faster to have GCC emit only aligned accesses.
>  KBUILD_CFLAGS += $(call cc-option,-mstrict-align)
>
> +# arch specific predefines for sparse
> +CHECKFLAGS += -D__riscv -D__riscv_xlen=$(BITS)
> +
>  head-y := arch/riscv/kernel/head.o
>
>  core-y += arch/riscv/kernel/ arch/riscv/mm/

Thanks!