linux-kernel - Re: [patch 3/8] x86/apic: Provide apic_ack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1806051339020.1591@nanos.tec.linutronix.de>
Date:   Tue, 5 Jun 2018 13:41:18 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Dou Liyang <douly.fnst@...fujitsu.com>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Borislav Petkov <bp@...en8.de>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        Song Liu <liu.song.a23@...il.com>,
        Joerg Roedel <jroedel@...e.de>,
        Mike Travis <mike.travis@....com>, stable@...r.kernel.org
Subject: Re: [patch 3/8] x86/apic: Provide apic_ack_irq()

On Tue, 5 Jun 2018, Dou Liyang wrote:
> > +{
> > +	if (unlikely(irqd_is_setaffinity_pending(irqd)))
> 
> Affinity pending is also judged in
> 
> > +		irq_move_irq(irqd);
> 
> If we can remove the if(...) statement here

That requires to fix all call sites in ia64 and that's why I didn't.  But
we can make irq_move_irq() an inline function and have the check in the
inline.

Thanks,

	tglx