linux-kernel - Re: [PATCH] Use an IDR to allocate apparmor secids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180605114734.GA20472@bombadil.infradead.org>
Date:   Tue, 5 Jun 2018 04:47:34 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     John Johansen <john.johansen@...onical.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use an IDR to allocate apparmor secids

On Mon, Jun 04, 2018 at 07:35:24PM -0700, John Johansen wrote:
> On 06/04/2018 07:27 PM, Matthew Wilcox wrote:
> > On Mon, Jun 04, 2018 at 06:27:09PM -0700, John Johansen wrote:
> >> hey Mathew,
> >>
> >> I've pulled this into apparmor-next and done the retuning of
> >> AA_SECID_INVALID a follow on patch. The reworking of the api to
> >> return the specific error type can wait for another cycle.
> > 
> > Oh ... here's what I currently have.  I decided that AA_SECID_INVALID
> > wasn't needed.
> > 
> well not needed in the allocation path, but definitely needed and it
> needs to be 0.
> 
> This is for catching some uninitialized or freed and zeroed values.
> The debug checks aren't in the current version, as they were
> residing in another debug patch, but I will pull them out into their
> own patch.

With the IDR, I don't know if you need it for debug.

	BUG_ON(label != idr_find(&aa_secids, label->secid))

should do the trick.