linux-kernel - Re: [PATCH] fs: stub out ioprio_check_cap for !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0zjnrTv=skGn_-df-R_CXDXT2Lhz=a+D2hzhDqMd9oFA@mail.gmail.com>
Date:   Tue, 5 Jun 2018 13:59:44 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Jeff Moyer <jmoyer@...hat.com>, Christoph Hellwig <hch@....de>,
        Adam Manzanares <adam.manzanares@....com>,
        Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: stub out ioprio_check_cap for !CONFIG_BLOCK

On Tue, Jun 5, 2018 at 1:47 PM, Arnd Bergmann <arnd@...db.de> wrote:
> When CONFIG_BLOCK is disabled, we now run into a link error:
>
> fs/aio.o: In function `aio_prep_rw':
> aio.c:(.text+0xf68): undefined reference to `ioprio_check_cap'
>
> Since the priorities are unused without block devices, this adds a stub
> that always returns success.
>
> Fixes: d9a08a9e616b ("fs: Add aio iopriority support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> Not sure if my assertion is correct, please check that returning zero
> actually makes sense here.

Nevermind, I just saw a different patch fixes this in today's linux-next

       Arnd