linux-kernel - Re: [GIT PULL] Device properties framework update for v4.18-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFw8yUOweiQSEp-ZHzEeSAGggZ0-Ksy0e4GQgEhKvmwLog@mail.gmail.com>
Date:   Tue, 5 Jun 2018 10:39:23 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Linux ACPI <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Device properties framework update for v4.18-rc1

On Tue, Jun 5, 2018 at 10:30 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Honestly, this looks questionable to me.
>
> I'm not talking about the changes themselves - I can live with them.
> But the _rationale_ is pure and utter garbage, and dangerously so.

Side note: I've merged it, and it's going through my build tests, so
it's really not that I hate the code.

But I really find that kind of one-sided rationale that ignores
reality unacceptable.

And I find it dangerous, because it *sounds* so "obviously correct" to
people who don't know any better. If you don't know that gcc
explicitly says that you should use unions to do type punning to avoid
aliasing issues, you might believe that union type punning is a bad
thing from that commit message.

So it's dangerously misleading, because lots of people have a
dangerous reverence for paper over reality.

In programming, "Appeal to Standards" should be considered a potential
logical fallacy. Standards have their place, but they definitely have
their caveats too.

                    Linus