linux-kernel - Re: [PATCH v2 2/2] x86: paravirt: make native_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUXecX5s+ZD9Nfp3uXCWRyD7zbBg5WgxCintR9Baco6smA@mail.gmail.com>
Date:   Tue, 5 Jun 2018 19:46:19 +0200
From:   Sedat Dilek <sedat.dilek@...il.com>
To:     "H. Peter Anvin" <hpa@...or.com>
Cc:     Nick Desaulniers <ndesaulniers@...gle.com>,
        akpm@...ux-foundation.org, ard.biesheuvel@...aro.org,
        aryabinin@...tuozzo.com, akataria@...are.com,
        boris.ostrovsky@...cle.com, brijesh.singh@....com,
        caoj.fnst@...fujitsu.com, gregkh@...uxfoundation.org,
        jan.kiszka@...mens.com, jarkko.sakkinen@...ux.intel.com,
        jgross@...e.com, jpoimboe@...hat.com,
        kirill.shutemov@...ux.intel.com, mingo@...hat.com,
        mjg59@...gle.com, mka@...omium.org, pombredanne@...b.com,
        rostedt@...dmis.org, tglx@...utronix.de, thomas.lendacky@....com,
        tweek@...gle.com, linux-efi@...r.kernel.org,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        virtualization@...ts.linux-foundation.org, astrachan@...gle.com,
        manojgupta@...gle.com, ghackmann@...gle.com, tstellar@...hat.com,
        keescook@...gle.com, yamada.masahiro@...ionext.com,
        michal.lkml@...kovi.net, linux-kbuild@...r.kernel.org,
        geert@...ux-m68k.org, will.deacon@....com, mawilcox@...rosoft.com,
        Arnd Bergmann <arnd@...db.de>, rientjes@...gle.com
Subject: Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline

On Tue, Jun 5, 2018 at 7:31 PM, H. Peter Anvin <hpa@...or.com> wrote:
> On 06/05/18 10:28, H. Peter Anvin wrote:
>> On 06/05/18 10:05, Nick Desaulniers wrote:
>>> +
>>> +/*
>>> + * void native_restore_fl(unsigned long flags)
>>> + * %rdi: flags
>>> + */
>>> +ENTRY(native_restore_fl)
>>> +    push %_ASM_DI
>>> +    popf
>>> +    ret
>>> +ENDPROC(native_restore_fl)
>>> +EXPORT_SYMBOL(native_restore_fl)
>>>
>>
>> To work on i386, this would have to be %_ASM_AX in that case.
>>
>> Something like this added to <asm/asm.h> might be useful; then you can
>> simply:
>>
>>       push %_ASM_ARG1
>>
>
> Version with fixed typo...

Small typo in the commit-subject... s/argument registes/argument registers

- sed@ -