[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 06 Jun 2018 11:24:59 +0200
From: Lucas Stach <l.stach@...gutronix.de>
To: Leonard Crestez <leonard.crestez@....com>,
Shawn Guo <shawnguo@...nel.org>, Marek Vasut <marex@...x.de>,
Fabio Estevam <fabio.estevam@....com>,
David Airlie <airlied@...ux.ie>
Cc: Robert Chiras <robert.chiras@....com>,
dri-devel@...ts.freedesktop.org,
Marco Franchi <marco.franchi@....com>,
Stefan Agner <stefan@...er.ch>,
Mirela Rabulea <mirela.rabulea@....com>,
Laurentiu Palcu <laurentiu.palcu@....com>,
Dong Aisheng <aisheng.dong@....com>, linux-imx@....com,
kernel@...gutronix.de, linux-kernel@...r.kernel.org
Subject: Re: [RFC 2/2] ARM: dts: imx6sl: Convert gpc to new bindings
Am Dienstag, den 05.06.2018, 20:11 +0300 schrieb Leonard Crestez:
> With old bindings imx_gpc_onecell_data always sets num_domains to 2 so
> the DISPMIX domain can't actually be referenced. The pd is still defined
> and pm core shuts it down as "unused" so display can't work.
>
> Converting to new gpc bindings by adding pgc nodes, also reference
> referencing the newly-defined &pu_disp domain from &lcdif.
>
> > Signed-off-by: Leonard Crestez <leonard.crestez@....com>
> ---
> arch/arm/boot/dts/imx6sl.dtsi | 35 ++++++++++++++++++++++++++++++++---
> 1 file changed, 32 insertions(+), 3 deletions(-)
>
> There are erratas regarding dispmix on 6sl so this might be wrong
>
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index ab6a7e2e7e8f..9982874fa39e 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -694,14 +694,42 @@
> > reg = <0x020dc000 0x4000>;
> > interrupt-controller;
> > #interrupt-cells = <3>;
> > interrupts = <0 89 IRQ_TYPE_LEVEL_HIGH>;
> > interrupt-parent = <&intc>;
> > - pu-supply = <®_pu>;
> > - clocks = <&clks IMX6SL_CLK_GPU2D_OVG>,
> > - <&clks IMX6SL_CLK_GPU2D_PODF>;
> > + clocks = <&clks IMX6SL_CLK_IPG>;
> > + clock-names = "ipg";
> > #power-domain-cells = <1>;
The above power-domain-cells needs to go away when using the new
binding.
Regards,
Lucas
> + pgc {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> +
> > + power-domain@0 {
> > + reg = <0>;
> > + #power-domain-cells = <0>;
> > + };
> +
> > > + pd_pu: power-domain@1 {
> > + reg = <1>;
> > + #power-domain-cells = <0>;
> > + power-supply = <®_pu>;
> > + clocks = <&clks IMX6SL_CLK_GPU2D_OVG>,
> > + <&clks IMX6SL_CLK_GPU2D_PODF>;
> > + };
> +
> > > + pd_disp: power-domain@2 {
> > + reg = <2>;
> > + #power-domain-cells = <0>;
> > + clocks = <&clks IMX6SL_CLK_IPG>,
> > + <&clks IMX6SL_CLK_LCDIF_AXI>,
> > + <&clks IMX6SL_CLK_LCDIF_PIX>,
> > + <&clks IMX6SL_CLK_EPDC_AXI>,
> > + <&clks IMX6SL_CLK_EPDC_PIX>,
> > + <&clks IMX6SL_CLK_PXP_AXI>;
> > + };
> > + };
> > };
>
> > > gpr: iomuxc-gpr@...0000 {
> > compatible = "fsl,imx6sl-iomuxc-gpr",
> > "fsl,imx6q-iomuxc-gpr", "syscon";
> @@ -752,10 +780,11 @@
> > clocks = <&clks IMX6SL_CLK_LCDIF_PIX>,
> > <&clks IMX6SL_CLK_LCDIF_AXI>,
> > <&clks IMX6SL_CLK_DUMMY>;
> > clock-names = "pix", "axi", "disp_axi";
> > status = "disabled";
> > + power-domains = <&pd_disp>;
> > };
>
> > > dcp: dcp@...c000 {
> > compatible = "fsl,imx6sl-dcp", "fsl,imx28-dcp";
> > reg = <0x020fc000 0x4000>;
Powered by blists - more mailing lists