[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 6 Jun 2018 12:37:34 +0200 (CEST)
From: Thomas Gleixner <tglx@...utronix.de>
To: Masatake YAMATO <yamato@...hat.com>
cc: x86@...nel.org, LKML <linux-kernel@...r.kernel.org>,
Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH] x86/iommu: Fix a typo in a macro parameter
On Wed, 6 Jun 2018, Masatake YAMATO wrote:
Can you please explain why 0 is the wrong value. That's not a typo, that's
a functional change and both the subject line and the changelog itself
should be explanatory.
Thanks,
tglx
> Signed-off-by: Masatake YAMATO <yamato@...hat.com>
> ---
> arch/x86/include/asm/iommu_table.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/iommu_table.h b/arch/x86/include/asm/iommu_table.h
> index 1fb3fd1a83c2..2a0d5f7d1ed1 100644
> --- a/arch/x86/include/asm/iommu_table.h
> +++ b/arch/x86/include/asm/iommu_table.h
> @@ -66,7 +66,7 @@ struct iommu_table_entry {
> #define IOMMU_INIT_POST(_detect) \
> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 0)
>
> -#define IOMMU_INIT_POST_FINISH(detect) \
> +#define IOMMU_INIT_POST_FINISH(_detect) \
> __IOMMU_INIT(_detect, pci_swiotlb_detect_4gb, NULL, NULL, 1)
>
> /*
> --
> 2.17.0
>
>
Powered by blists - more mailing lists