linux-kernel - Re: [PATCH] fix NULL device in ipmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <14953c8b-e461-15d1-798f-39a1adbac0a6@acm.org>
Date:   Wed, 6 Jun 2018 09:04:14 -0500
From:   Corey Minyard <minyard@....org>
To:     Meelis Roos <mroos@...ux.ee>,
        openipmi-developer@...ts.sourceforge.net
Cc:     Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fix NULL device in ipmi_si error message

On 06/06/2018 08:11 AM, Meelis Roos wrote:
> I noticed that 4.17.0 logs the follwing during ipmi_si setup:
>
>   ipmi_si 0000:01:04.6: probing via PCI
>   (NULL device *): Could not setup I/O space
>   ipmi_si 0000:01:04.6: [mem 0xf5ef0000-0xf5ef00ff] regsize 1 spacing 1 irq 21
>
> Fix the "NULL device *) by moving io.dev assignment before its potential
> use by ipmi_pci_probe_regspacing().
>
> Result:
>   ipmi_si 0000:01:04.6: probing via PCI
>   ipmi_si 0000:01:04.6: Could not setup I/O space
>   ipmi_si 0000:01:04.6: [mem 0xf5ef0000-0xf5ef00ff] regsize 1 spacing 1 irq 21

Looks good, queued for next release.

It does raise the question of why the I/O space setup is failing on some 
system (other have
reported this, too).  I'm working on that.

Thanks,

-corey

> Signed-off-by: Meelis Roos <mroos@...ux.ee>
>
> diff --git a/drivers/char/ipmi/ipmi_si_pci.c b/drivers/char/ipmi/ipmi_si_pci.c
> index f54ca6869ed2..022e03634ce2 100644
> --- a/drivers/char/ipmi/ipmi_si_pci.c
> +++ b/drivers/char/ipmi/ipmi_si_pci.c
> @@ -120,6 +120,8 @@ static int ipmi_pci_probe(struct pci_dev *pdev,
>   	}
>   	io.addr_data = pci_resource_start(pdev, 0);
>   
> +	io.dev = &pdev->dev;
> +
>   	io.regspacing = ipmi_pci_probe_regspacing(&io);
>   	io.regsize = DEFAULT_REGSIZE;
>   	io.regshift = 0;
> @@ -128,8 +130,6 @@ static int ipmi_pci_probe(struct pci_dev *pdev,
>   	if (io.irq)
>   		io.irq_setup = ipmi_std_irq_setup;
>   
> -	io.dev = &pdev->dev;
> -
>   	dev_info(&pdev->dev, "%pR regsize %d spacing %d irq %d\n",
>   		&pdev->resource[0], io.regsize, io.regspacing, io.irq);
>   
>