linux-kernel - Re: [PATCH] hwmon: (dell-smm) Disable fan support for Dell XPS13 9333

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jun 2018 08:39:10 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Pali Rohár <pali.rohar@...il.com>,
        Helge Eichelberg <kernelorg@...henberg.name>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Disable fan support for Dell XPS13 9333

On 06/06/2018 08:21 AM, Pali Rohár wrote:
> On Tuesday 05 June 2018 19:38:32 Helge Eichelberg wrote:
>> Calling fan related SMM functions implemented by Dell BIOS firmware on Dell
>> XPS13 9333 freeze kernel for about 500ms. Until Dell fixes it we need to
>> disable fan support for Dell XPS13 9333.
> 
> Hi! Have you reported this firmware bug to Dell?
> 
> Also we should probably match also BIOS version and do not apply this
> blacklist quirk for BIOS versions in which Dell fixed it.
> 

Is it known to have been fixed ? If so, why report it to Dell ?

If the problem is not known to be fixed, we have no BIOS version to match against.

Guenter

>> Via "force" module param fan support can be enabled.
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=195751
>> Signed-off-by: Helge Eichelberg <kernelorg@...henberg.name>
>> ---
>>   drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
>> index bf3bb7e1adab..9d3ef879dc51 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -1074,6 +1074,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
>>   			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Vostro 3360"),
>>   		},
>>   	},
>> +	{
>> +		.ident = "Dell XPS13 9333",
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
>> +		},
>> +	},
>>   	{ }
>>   };
>>   
>