[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 6 Jun 2018 15:26:28 +0200
From: Samuel Thibault <samuel.thibault@...-lyon.org>
To: "Speakup is a screen review system for Linux."
<speakup@...ux-speakup.org>
Cc: devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: speakup: refactor synths array to use a list
Hello,
Justin Skists, le lun. 04 juin 2018 10:52:12 +0100, a ecrit:
> The synths[] array is a collection of synths acting like a list.
> There is no need for synths to be an array, so refactor synths[] to use
> standard kernel list_head API, instead, and modify the usages to suit.
> As a side-effect, the maximum number of synths has also become redundant.
This looks good to me,
Reviewed-by: Samuel Thibault <samuel.thibault@...-lyon.org>
Did you test to e.g. insmod speakup_soft ; insmod speakup_dummy ; rmmod
speakup_soft ; rmmod speakup_dummy
to make sure it did work correctly?
I'd also rather see it tested in the real wild before committing. Could
somebody on the speakup mailing list test the patch? (which I have
re-attached as a file for conveniency).
Samuel
View attachment "patch" of type "text/plain" (2999 bytes)
Powered by blists - more mailing lists