linux-kernel - Re: [PATCH] parport: Add support for the WCH384 4S multi-IO card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jun 2018 20:04:33 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Matt Turner <mattst88@...il.com>
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Sergej Pupykin <ml@...gej.pp.ru>
Subject: Re: [PATCH] parport: Add support for the WCH384 4S multi-IO card

On Wed, Jun 6, 2018 at 9:07 AM, Matt Turner <mattst88@...il.com> wrote:
> On Sat, May 26, 2018 at 12:35 PM, Matt Turner <mattst88@...il.com> wrote:
>> This Multi-IO card has one serial 16550-like serial connectors. Here's
>> the lspci output, after this commit is applied:
>>
>> 01:00.0 Serial controller [0700]: Device [1c00:3470] (rev 10) (prog-if 05 [16850])
>>         Subsystem: Device [1c00:3470]
>>         Flags: fast devsel, IRQ 16
>>         I/O ports at e000 [size=256]
>>         Memory at f0100000 (32-bit, prefetchable) [size=32K]
>>         I/O ports at e100 [size=4]
>>         Expansion ROM at f7d00000 [disabled] [size=32K]
>>         Capabilities: [60] Power Management version 3
>>         Capabilities: [68] MSI: Enable- Count=1/32 Maskable+ 64bit+
>>         Capabilities: [80] Express Legacy Endpoint, MSI 00
>>         Capabilities: [100] Advanced Error Reporting
>>         Kernel driver in use: parport_serial
>>
>> This card was already added to the blacklist of 8250_pci.c in commit
>> 72a3c0e4e662 ("tty: Add support for the WCH384 4S multi-IO card").

First of all, this patch is in conflict with tty-next AFAICS.

Second, what card w/o parport should do in parport_serial?

Third, this patch brings more mess: either you should remove the code
from 8250_pci, or do not add it here. See below.

it looks like the mentioned patch mistakenly added it to blacklist by
unknown reason.

Feels to me like NAK to this one.

And btw, you missed s letter in the model name across the code and I
don't see any of cards there listed with numports == 0.

>>
>> Cc: Sergej Pupykin <ml@...gej.pp.ru>
>> Signed-off-by: Matt Turner <mattst88@...il.com>
>> ---
>
> Hi,
>
> Can I expect this to be picked up for the 4.18 merge window?
>
> Matt



-- 
With Best Regards,
Andy Shevchenko