[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 6 Jun 2018 14:15:56 -0600
From: Jason Gunthorpe <jgg@...lanox.com>
To: linux-kernel@...r.kernel.org,
Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Randy Dunlap <rdunlap@...radead.org>,
Andy Whitcroft <apw@...onical.com>,
Joe Perches <joe@...ches.com>,
Jonathan Corbet <corbet@....net>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] clang-format: Set IndentWrappedFunctionNames false
The true option causes this indenting for functions:
static struct something_very_very_long *
function(void *arg)
{
While a quick survey suggests that the usual Linux fallback is the GNU
style:
static struct something_very_very_long *
function(void *arg)
{
Eg as seen in:
kernel/cpu.c
kernel/fork.c
and other places.
Signed-off-by: Jason Gunthorpe <jgg@...lanox.com>
---
.clang-format | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for making this Miguel!
I've been using clang-format for years with the kernel and noticed it
was performing just a little different than I would have expected.
AFAIK the above describes the more common choice in the code base?
Not sure who's tree this is supposed to go through.. Andrew I guess?
diff --git a/.clang-format b/.clang-format
index faffc0d5af4eeb..1d5da22e0ba50c 100644
--- a/.clang-format
+++ b/.clang-format
@@ -382,7 +382,7 @@ IncludeIsMainRegex: '(Test)?$'
IndentCaseLabels: false
#IndentPPDirectives: None # Unknown to clang-format-5.0
IndentWidth: 8
-IndentWrappedFunctionNames: true
+IndentWrappedFunctionNames: false
JavaScriptQuotes: Leave
JavaScriptWrapImports: true
KeepEmptyLinesAtTheStartOfBlocks: false
--
2.17.0
Powered by blists - more mailing lists