linux-kernel - Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZghHkbyKrP=QAT5DSPEJ07hp07wU+UvrZFs7z2oOLtXg@mail.gmail.com>
Date:   Thu, 7 Jun 2018 09:25:12 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Sebastian Gottschall <s.gottschall@...wrt.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>,
        Timur Tabi <timur@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Sasha Levin <alexander.levin@...rosoft.com>
Subject: Re: [PATCH 4.16 269/272] pinctrl: msm: Use dynamic GPIO numbering

On Thu, May 31, 2018 at 1:21 PM, Sebastian Gottschall
<s.gottschall@...wrt.com> wrote:

> this patch creates a regression for me. on ipq8064 the systems gpios now
> start somewhere in the sky
(...)
> this broke my userspace gpio handling. i can override this, but still it
> doesnt look correct since there is a hole at the beginng likelly reserved by
> unused arm gpios

Out of curiosity: what is this userspace?

We do not break userspace, so I guess we should put in some hack
to keep the base 0 on ipq8064 then, but as pointed out by Bjorn
there will be problems when we get multiple gpiochips in later
platforms so it is just a stopgap solution.

Have you looked into using the new character device with your
userspace, either as shown in the examples:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/gpio

or using libgpiod:
https://git.kernel.org/pub/scm/libs/libgpiod/libgpiod.git/

Yours,
Linus Walleij