linux-kernel - Re: [PATCH 3.16 070/410] ARM: dts: omap3-n900: Fix the audio CODEC's reset pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10ae263892588639ddc1614dbd4434e4e11e9afa.camel@decadent.org.uk>
Date:   Thu, 07 Jun 2018 19:20:22 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     "Andrew F. Davis" <afd@...com>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     akpm@...ux-foundation.org, Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH 3.16 070/410] ARM: dts: omap3-n900: Fix the audio
 CODEC's reset pin

On Thu, 2018-06-07 at 10:03 -0500, Andrew F. Davis wrote:
> On 06/07/2018 09:05 AM, Ben Hutchings wrote:
> > 3.16.57-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> 
> 
> This relies on a patch that may not have been back-ported this far back,
> it is more safe to not take this patch.

I agree, and I should have spotted that since I pointed it out in an
earlier review.

Ben.

> 
> > ------------------
> > 
> > From: "Andrew F. Davis" <afd@...com>
> > 
> > commit 7be4b5dc7ffa9499ac6ef33a5ffa9ff43f9b7057 upstream.
> > 
> > The correct DT property for specifying a GPIO used for reset
> > is "reset-gpios", fix this here.
> > 
> > Fixes: 14e3e295b2b9 ("ARM: dts: omap3-n900: Add TLV320AIC3X support")
> > 
> > Signed-off-by: Andrew F. Davis <afd@...com>
> > Signed-off-by: Tony Lindgren <tony@...mide.com>
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> > ---
> >  arch/arm/boot/dts/omap3-n900.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > --- a/arch/arm/boot/dts/omap3-n900.dts
> > +++ b/arch/arm/boot/dts/omap3-n900.dts
> > @@ -427,7 +427,7 @@
> >  	tlv320aic3x: tlv320aic3x@18 {
> >  		compatible = "ti,tlv320aic3x";
> >  		reg = <0x18>;
> > -		gpio-reset = <&gpio2 28 GPIO_ACTIVE_HIGH>; /* 60 */
> > +		reset-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; /* 60 */
> >  		ai3x-gpio-func = <
> >  			0 /* AIC3X_GPIO1_FUNC_DISABLED */
> >  			5 /* AIC3X_GPIO2_FUNC_DIGITAL_MIC_INPUT */
> > @@ -444,7 +444,7 @@
> >  	tlv320aic3x_aux: tlv320aic3x@19 {
> >  		compatible = "ti,tlv320aic3x";
> >  		reg = <0x19>;
> > -		gpio-reset = <&gpio2 28 GPIO_ACTIVE_HIGH>; /* 60 */
> > +		reset-gpios = <&gpio2 28 GPIO_ACTIVE_LOW>; /* 60 */
> >  
> >  		AVDD-supply = <&vmmc2>;
> >  		DRVDD-supply = <&vmmc2>;
> > 
-- 
Ben Hutchings
The most exhausting thing in life is being insincere.
                                                 - Anne Morrow Lindberg


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)