linux-kernel - Re: [PATCH v2] hv_netvsc: Fix a network regression after ifdown/ifup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180607.162443.917679158498262601.davem@davemloft.net>
Date:   Thu, 07 Jun 2018 16:24:43 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     decui@...rosoft.com
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        netdev@...r.kernel.org, devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, olaf@...fle.de, apw@...onical.com,
        jasowang@...hat.com, vkuznets@...hat.com,
        marcelo.cerri@...onical.com, jopoulso@...rosoft.com,
        Stephen.Zarkos@...rosoft.com
Subject: Re: [PATCH v2] hv_netvsc: Fix a network regression after
 ifdown/ifup

From: Dexuan Cui <decui@...rosoft.com>
Date: Wed, 6 Jun 2018 21:32:51 +0000

> 
> Recently people reported the NIC stops working after
> "ifdown eth0; ifup eth0". It turns out in this case the TX queues are not
> enabled, after the refactoring of the common detach logic: when the NIC
> has sub-channels, usually we enable all the TX queues after all
> sub-channels are set up: see rndis_set_subchannel() ->
> netif_device_attach(), but in the case of "ifdown eth0; ifup eth0" where
> the number of channels doesn't change, we also must make sure the TX queues
> are enabled. The patch fixes the regression.
> 
> Fixes: 7b2ee50c0cd5 ("hv_netvsc: common detach logic")
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>

Applied and queued up for -stable.